Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade nightly wheels to ROCm6.2.4 and manylinux2_28 #6016

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Upgrade nightly wheels to ROCm6.2.4 and manylinux2_28 #6016

merged 2 commits into from
Dec 6, 2024

Conversation

jithunnair-amd
Copy link
Collaborator

No description provided.

@vercel Vercel
Copy link

vercel bot commented Dec 6, 2024

@jithunnair-amd is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Dec 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 2:09am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 6, 2024

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@jithunnair-amd
Copy link
Collaborator Author

jithunnair-amd commented Dec 6, 2024 •
edited
Loading

@clee2000 @atalman @huydhn I think we should update some README on how to update these assets json files. I was able to do it by a slightly hacky method:

  1. cd test-infra
  2. cp -a tools/tests/test_generate_binary_build_matrix.py .
  3. python3 test_generate_binary_build_matrix.py --update-reference-files

@jithunnair-amd jithunnair-amd mentioned this pull request Dec 6, 2024
Open
5 tasks
@jithunnair-amd jithunnair-amd marked this pull request as ready for review December 6, 2024 04:09
@jithunnair-amd
Copy link
Collaborator Author

@atalman All binary build checks for ROCm passed, and used ROCm manylinux2_28 docker images as intended. Also confirmed that both torchaudio and torchvision used the -D_GLIBCXX_USE_CXX11_ABI=1 setting as intended for ROCm manylinux2_28 wheels. Please approve and merge.

@jithunnair-amd
Copy link
Collaborator Author

jithunnair-amd commented Dec 6, 2024 •
edited
Loading

Also, noticed that the PR runs py3.9 builds instead of py3.12, which seems to have been the intent of the generate_binary_build_matrix.py script based on the header comments. Not a big concern, but still filed an issue #6017 to consider syncing the comment with the implementation.

@huydhn huydhn merged commit e717b51 into pytorch:main Dec 6, 2024
70 of 71 checks passed
@jithunnair-amd jithunnair-amd deleted the upgrade_nightly_wheels_to_rocm6.2.4 branch December 6, 2024 21:45
vkuzo added a commit to pytorch/ao that referenced this pull request Dec 9, 2024
@vkuzo
update test-infra to release version
242b04d 
Summary:

pytorch/test-infra#6016 landed recently which is
breaking our ROCm builds

We point to a special branch of test-infra created just before this PR
to unblock the v0.7.0 release.

Test Plan: CI

Reviewers:

Subscribers:

Tasks:

Tags:
@vkuzo vkuzo mentioned this pull request Dec 9, 2024
Merged
vkuzo added a commit to pytorch/ao that referenced this pull request Dec 9, 2024
@vkuzo
update test-infra to release version
6d50691 
Summary:

pytorch/test-infra#6016 landed recently which is
breaking our ROCm builds

We point to a special branch of test-infra created just before this PR
to unblock the v0.7.0 release.

Test Plan: CI

Reviewers:

Subscribers:

Tasks:

Tags:
vkuzo added a commit to pytorch/ao that referenced this pull request Dec 9, 2024
@vkuzo @atalman
update test-infra to release version (#1391)
e39126a 
* update test-infra to release version

Summary:

pytorch/test-infra#6016 landed recently which is
breaking our ROCm builds

We point to a special branch of test-infra created just before this PR
to unblock the v0.7.0 release.

Test Plan: CI

Reviewers:

Subscribers:

Tasks:

Tags:

* Update .github/workflows/build_wheels_linux.yml

---------

Co-authored-by: Andrey Talman <atalman@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

@atalman atalman Awaiting requested review from atalman

Assignees
No one assigned
Labels
ciflow/rocm CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jithunnair-amd @huydhn @facebook-github-bot